Skip to content

feat: add new GenAI SDK count tokens samples #10145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jdomingr
Copy link
Contributor

@jdomingr jdomingr commented Aug 6, 2025

Description

Add new count tokens samples:

  • Count tokens compute with text
  • Count tokens response with text
  • Update count tokens test and CountTokensWithText

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Sample Format Guide
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • Please merge this PR for me once it is approved

@jdomingr jdomingr requested review from yoshi-approver and a team as code owners August 6, 2025 19:47
Copy link

snippet-bot bot commented Aug 6, 2025

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Aug 6, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @jdomingr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've added new sample code to the GenAI SDK to demonstrate different ways of counting tokens. Specifically, this PR introduces samples for computing tokens directly from text input and for extracting token counts from the usage metadata of a generated content response. This enhances the existing token counting examples and provides more comprehensive guidance for developers.

Highlights

  • New Sample: Compute Tokens from Text: I've introduced CountTokensComputeWithText.java which shows how to use the computeTokens method to get detailed token information (like token IDs and actual token strings) for a given text input.
  • New Sample: Count Tokens from Response Metadata: I've added CountTokensResponseWithText.java to illustrate how to retrieve prompt and candidate token counts from the usageMetadata field of a GenerateContentResponse.
  • Updated Tests: I've updated CountTokensIT.java with new integration tests to ensure the correctness and functionality of the newly added token counting samples.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces new samples for counting tokens with the GenAI SDK, covering computeTokens and generateContent API calls. The changes include two new sample files and corresponding integration tests. Additionally, an existing sample file has been cleaned up by removing unused imports. The new samples are a valuable addition. My review includes suggestions to improve code readability in one of the new samples and to enhance the robustness of a new test case.

@gericdong gericdong added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 7, 2025
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 7, 2025
@gericdong gericdong added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 7, 2025
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants